[lwlan-devel] [patch] wlan-udev.sh possible empty variable

[Tormod Volden]

On 5/19/07, Richard Kennedy wrote:
> I'm glad that you haven't seen this :)
>
> In practice you shouldn't have a problem though, because that module
> parameter has been in the driver for a long time.
>
> But, you are right we should do something if that file test fails.
> maybe something like this ?
>
> if [ -f $WEXT_PARAM ]; then
>         WLAN_WEXT=`cat $WEXT_PARAM`
> else
>         echo "wext module parameter not found! card removed ?"
>         exit 1
> fi
>
> Cheers
> Richard

I mistakenly thought this was a relative new parameter, which it is
not. So it's no practical issue at all :) But I think, if your script
is careful enough to check for WEXT_PARAM it should also not bail out
in error if it doesn't exist, in order to be consistent in terms of
coding.

I don't think the WEXT_PARAM should be used to check for the existence
of the card either. Can't we just ignore it, like my (ok, practically
useless) patch does?

Tormod